Tracing flame #4030
Closed
Tracing flame #4030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
added
Priority: Medium
|
Blocked on #3810 |
JonathanWoollett-Light
force-pushed
the
tracing-flame
branch
7 times, most recently
from
0beb6fc to
de74b3c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4030 +/- ##
===========================================
- Coverage 82.66% 70.97% -11.70%
===========================================
Files 221 219 -2
Lines 28192 9096 -19096
===========================================
- Hits 23306 6456 -16850
+ Misses 4886 2640 -2246
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JonathanWoollett-Light
force-pushed
the
tracing-flame
branch
from
de74b3c to
86f1c26
Compare
added 7 commits
August 17, 2023 17:15
Re-exports logging macros from `logger` to allow more atomic changes in `logger`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Replaces `log` with `tracing` and the custom logger with `tracing_subscriber::Fmt`. Adding support for re-configuring the logger at run-time and removing the old logger format. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Add the ` FilterFn` layer to support filtering by crates, modules and spans. With `tracing::instrument` spans wrap functions, this would support filtering to specific functions. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Adds code instrumentation. This opens support for tracing and profiling via this instrumentation. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Runs `clippy-tracing --check` to assert code is properly instrumented. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Enables the `max_level_debug` tracing features to omit instrumentation by default. Signed-off-by: Jonathan Woollett-LIght <jcawl@amazon.co.uk>
Adds `tracing_flame` as code instrumentation based profiler that can be used to profile Firecracker. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
tracing-flame
branch
from
86f1c26 to
0c24377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.